gortiz commented on code in PR #10292:
URL: https://github.com/apache/pinot/pull/10292#discussion_r1112995453
##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotConnection.java:
##########
@@ -38,11 +40,16 @@
public class PinotConnection extends AbstractBaseConnection {
private static final Logger LOGGER =
LoggerFactory.getLogger(Connection.class);
+ protected static final String[] POSSIBLE_QUERY_OPTIONS = {
+ QueryOptionKey.ENABLE_NULL_HANDLING,
+ QueryOptionKey.USE_MULTISTAGE_ENGINE
+ };
private org.apache.pinot.client.Connection _session;
private boolean _closed;
private String _controllerURL;
private PinotControllerTransport _controllerTransport;
- private final boolean _enableNullHandling;
+ private final Map<String, Boolean> _queryOptions = new HashMap<String,
Boolean>();
Review Comment:
I think it is nice to generalise the query options but... couldn't values be
other things like ints? I would prefer to use Object as the value of the map
and change `DriverUtils::createSetQueryOptionString` to be able to deal with,
at least, booleans and integers. Strings would be also fine, but they I'm not
sure whether they could be used to do SQL injections or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
