klsince commented on code in PR #10553:
URL: https://github.com/apache/pinot/pull/10553#discussion_r1169271966


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -460,6 +467,7 @@ public TableConfig build() {
     indexingConfig.setAggregateMetrics(_aggregateMetrics);
     
indexingConfig.setOptimizeDictionaryForMetrics(_optimizeDictionaryForMetrics);
     
indexingConfig.setNoDictionarySizeRatioThreshold(_noDictionarySizeRatioThreshold);
+    indexingConfig.setTierOverwrites(_tierOverwrites);

Review Comment:
   Both tableIndexConfig (i.e. the indexingConfig object here) and 
fieldConfigList have their own `tierOverwrites`. The fieldConfigList (with 
tierOverwrites on individual fieldConfig as needed by the caller) is provided 
to this TableConfigBuilder separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to