npawar commented on code in PR #10553:
URL: https://github.com/apache/pinot/pull/10553#discussion_r1169304072
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -460,6 +467,7 @@ public TableConfig build() {
indexingConfig.setAggregateMetrics(_aggregateMetrics);
indexingConfig.setOptimizeDictionaryForMetrics(_optimizeDictionaryForMetrics);
indexingConfig.setNoDictionarySizeRatioThreshold(_noDictionarySizeRatioThreshold);
+ indexingConfig.setTierOverwrites(_tierOverwrites);
Review Comment:
clarified from offline discussion (method name is a bit confusing as it's on
top level TableConfigBuilder, but can only be used to set indexingConfig). This
can be addressed separately as it only affects tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
