gortiz commented on code in PR #11673:
URL: https://github.com/apache/pinot/pull/11673#discussion_r1335857827
##########
pinot-core/src/test/java/org/apache/pinot/core/data/function/JsonFunctionsTest.java:
##########
@@ -137,4 +137,19 @@ public Object[][] jsonFunctionsDataProvider()
});
return inputs.toArray(new Object[0][]);
}
+
+ @Test(description = "jsonFormat(Java null) should return Java null")
+ public void jsonFormatWithJavaNullReturnsJavaNull() {
+ GenericRow row = new GenericRow();
+ row.putValue("jsonMap", null);
+ testFunction("json_format(jsonMap)", Lists.newArrayList("jsonMap"), row,
null);
Review Comment:
This test fails if executed in master. Instead of Java null, what was
returned was the String "null"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
