gortiz commented on code in PR #11673: URL: https://github.com/apache/pinot/pull/11673#discussion_r1335858446
########## pinot-spi/src/main/java/org/apache/pinot/spi/annotations/ScalarFunction.java: ########## @@ -46,11 +46,16 @@ boolean enabled() default true; - // If empty, FunctionsRegistry registers the method name as function name; - // If not empty, FunctionsRegistry only registers the function names specified here, the method name is ignored. + /** + * If empty, FunctionsRegistry registers the method name as function name; + * If not empty, FunctionsRegistry only registers the function names specified here, the method name is ignored. + */ Review Comment: Just applying the Boy Scouting Rule, “Always leave the code you are working on a little bit better than you found it.” ########## pinot-spi/src/main/java/org/apache/pinot/spi/annotations/ScalarFunction.java: ########## @@ -46,11 +46,16 @@ boolean enabled() default true; - // If empty, FunctionsRegistry registers the method name as function name; - // If not empty, FunctionsRegistry only registers the function names specified here, the method name is ignored. + /** + * If empty, FunctionsRegistry registers the method name as function name; + * If not empty, FunctionsRegistry only registers the function names specified here, the method name is ignored. + */ Review Comment: Just applying the Boy Scouting Rule, “Always leave the code you are working on a little bit better than you found it.” -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
