Jackie-Jiang commented on code in PR #11673:
URL: https://github.com/apache/pinot/pull/11673#discussion_r1336338296
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/JsonFunctions.java:
##########
@@ -79,6 +79,9 @@ public static String toJsonMapStr(@Nullable Map map)
@ScalarFunction(nullableParameters = true)
public static String jsonFormat(Object object)
throws JsonProcessingException {
+ if (object == null) {
Review Comment:
This is intentionally added in #8382. If we want to return null, removing
the `nullableParameters = true` will achieve that. Any specific reason why you
don't want string `'null'`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
