gortiz commented on PR #11673: URL: https://github.com/apache/pinot/pull/11673#issuecomment-1734919039
> Got it! Just wondering for json_format(), what kind of user input could lead to a JsonNode.isNull()? Would a "null" string value result in a JsonNode that's isNull()? Yes > This is intentionally added in https://github.com/apache/pinot/pull/8382. If we want to return null, removing the nullableParameters = true will achieve that. Any specific reason why you don't want string 'null'? I guess to conserve the nullability. I don't have a strong preference, but some users have been asking to change the behavior. Maybe it is just better to keep the old behavior and to specify the null semantic in the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
