walterddr commented on code in PR #11731: URL: https://github.com/apache/pinot/pull/11731#discussion_r1344749822
########## pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/ScalarFunctions.java: ########## @@ -56,6 +56,14 @@ public static byte[] stPoint(double x, double y) { * @return the created point */ @ScalarFunction + public static byte[] stPoint(double x, double y, int isGeography) { + return stPoint(x, y, isGeography == 1); + } + + /** + * TODO: Add @ScalarFunction annotation when we can support the same function name, number of parameters with a + * different type. + */ public static byte[] stPoint(double x, double y, boolean isGeography) { Review Comment: let's wait until #11726 once merged we can change the 3rd arg to be Object and it will utilize the Transform function signature to match this one and we can convert based on what 3rd argument is by checking the `isInstanceOf` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org