walterddr commented on code in PR #11731:
URL: https://github.com/apache/pinot/pull/11731#discussion_r1344842123
##########
pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/ScalarFunctions.java:
##########
@@ -56,6 +56,14 @@ public static byte[] stPoint(double x, double y) {
* @return the created point
*/
@ScalarFunction
+ public static byte[] stPoint(double x, double y, int isGeography) {
+ return stPoint(x, y, isGeography == 1);
+ }
+
+ /**
+ * TODO: Add @ScalarFunction annotation when we can support the same
function name, number of parameters with a
+ * different type.
+ */
public static byte[] stPoint(double x, double y, boolean isGeography) {
Review Comment:
#11726 is merged, we should change the boolean to Object and check the 3rd
argument whether it is a boolean or integer, simultaneously we also need to
change TransformFunctionType ST_POINT to allow 3rd argument to be either
Numeric or Boolean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
