walterddr commented on code in PR #11731:
URL: https://github.com/apache/pinot/pull/11731#discussion_r1344842781


##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/GeoSpatialTest.java:
##########
@@ -261,6 +268,39 @@ public void testStPointFunction(boolean 
useMultiStageQueryEngine)
     }
   }
 
+  @Test(dataProvider = "useV2QueryEngine")
+  public void testStPointFunctionWithV2(boolean useMultiStageQueryEngine)
+      throws Exception {
+    setUseMultiStageQueryEngine(useMultiStageQueryEngine);
+    String query =
+        String.format("Select "
+                + "ST_Point(a.st_x, a.st_y, -1), "
+                + "ST_Point(a.st_x, a.st_y, 1), "

Review Comment:
   should test both numeric and boolean



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to