vvivekiyer commented on code in PR #13574:
URL: https://github.com/apache/pinot/pull/13574#discussion_r1673281628
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AllowAllAccessFactory.java:
##########
@@ -24,7 +24,7 @@
public class AllowAllAccessFactory implements AccessControlFactory {
private static final AccessControl ALLOW_ALL_ACCESS = new AccessControl() {
@Override
- public boolean hasDataAccess(HttpHeaders httpHeaders, String tableName) {
+ public boolean hasAccess(String tableName, AccessType accessType,
HttpHeaders httpHeaders, String endpointUrl) {
Review Comment:
Perhaps we can remove this function as the default implementation returns
true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
