vvivekiyer commented on code in PR #13574:
URL: https://github.com/apache/pinot/pull/13574#discussion_r1674861091
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java:
##########
@@ -158,7 +158,7 @@ public Response downloadSegment(
boolean hasDataAccess;
try {
AccessControl accessControl = _accessControlFactory.create();
- hasDataAccess = accessControl.hasDataAccess(httpHeaders, tableName);
+ hasDataAccess = accessControl.hasAccess(tableName, AccessType.READ,
httpHeaders, null);
Review Comment:
@abhioncbr Can we please pass the endpointUrl
`Actions.Table.DOWNLOAD_SEGMENT` here and in PinotQueryResource (ideally we
should pass it in all places where `hasAccess` is called if not done already).
This will allow callers to have different READ restrictions for each endpoint.
Internally at Linkedin, we have different restrictions on READ access for
downloadSegment and query endpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
