soumitra-st commented on code in PR #13574:
URL: https://github.com/apache/pinot/pull/13574#discussion_r1675023332
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java:
##########
@@ -158,7 +158,7 @@ public Response downloadSegment(
boolean hasDataAccess;
try {
AccessControl accessControl = _accessControlFactory.create();
- hasDataAccess = accessControl.hasDataAccess(httpHeaders, tableName);
+ hasDataAccess = accessControl.hasAccess(tableName, AccessType.READ,
httpHeaders, Actions.Table.DOWNLOAD_SEGMENT);
Review Comment:
Same here, Actions.Table.DOWNLOAD_SEGMENT action used as endpointUrl. Shall
we pass null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
