ivankelly commented on a change in pull request #3677: PIP-30: interface and
mutual change authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r262898418
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java
##########
@@ -33,9 +36,12 @@
private final AuthenticationDataSource authenticationDataSource;
private final String authRole;
- public OneStageAuthenticationState(AuthenticationDataSource
authenticationDataSource,
+ public OneStageAuthenticationState(AuthData authData,
+ SocketAddress remoteAddress,
+ SSLSession sslSession,
AuthenticationProvider provider) throws
AuthenticationException {
- this.authenticationDataSource = authenticationDataSource;
+ this.authenticationDataSource = new AuthenticationDataCommand(
+ new String(authData.getBytes(), Charset.forName("UTF-8")),
remoteAddress, sslSession);;
Review comment:
java.nio.charset.StandardCharsets.UTF_8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
