ivankelly commented on a change in pull request #3677: PIP-30: interface and
mutual change authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r264711983
##########
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/common/api/AuthData.java
##########
@@ -20,8 +20,12 @@
import lombok.Data;
+import static java.nio.charset.StandardCharsets.UTF_8;
+
@Data(staticConstructor="of")
public final class AuthData {
+ public static byte[] INIT_AUTH_DATA = "init".getBytes(UTF_8);
Review comment:
"init" is too generic here. It's not outside the realm of possibility that
some auth protocol would send "init" in as the challenge. Add something more
specific to pulsar. "PulsarAuthInit" or so
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
