ivankelly commented on a change in pull request #3677: PIP-30: interface and
mutual change authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r264287574
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -543,10 +545,7 @@ protected void handleConnect(CommandConnect connect) {
connect.hasOriginalPrincipal() ?
connect.getOriginalPrincipal() : null,
sslSession);
- AuthenticationDataSource authenticationData =
authenticationProvider
- .newAuthDataSource(clientData, remoteAddress, sslSession);
- authState =
authenticationProvider.newAuthState(authenticationData);
-
+ authState = authenticationProvider.newAuthState(clientData,
remoteAddress, sslSession);
Review comment:
clientData is being used twice here. It would make more sense to remove it
from the call to newAuthState and only use it via the call to doAuthentication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
