ivankelly commented on a change in pull request #3677: PIP-30: interface and 
mutual change authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r264284594
 
 

 ##########
 File path: 
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationState.java
 ##########
 @@ -40,7 +40,7 @@
     /**
      * Challenge passed in auth data and get response data.
      */
-    AuthData authenticate(AuthData authData) throws IOException;
+    AuthData authenticate(AuthData authData) throws IOException, 
AuthenticationException;
 
 Review comment:
   why would this throw IOException? I think AuthenticationException is enough.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to