BewareMyPower commented on code in PR #288: URL: https://github.com/apache/pulsar-client-node/pull/288#discussion_r1073613508
########## tests/load-test.sh: ########## @@ -0,0 +1,42 @@ +#!/bin/bash Review Comment: But `pkg/linux` directory should represent packaging the Node.js client on Linux. The script here is to test `load_test.js` on Linux systems. Assuming there are 3 scripts (e.g. `load-test-win.sh`, `load-test-osx.sh`, `load-test-linux.sh`) that test `load_test.js` on Windows, macOS and Linux. Do you think it's better to put these scripts under three different directories like `pkg/windows`, `pkg/linux/` and `pkg/macos`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
