BewareMyPower commented on code in PR #288:
URL:
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1073627622
##########
.github/workflows/ci-pr-validation.yml:
##########
@@ -167,6 +167,14 @@ jobs:
docker run -i -v $PWD:/pulsar-client-node build:latest \
/pulsar-client-node/pkg/linux/build-napi-inside-docker.sh
+ - name: Test NAPI file in other containers
+ if: matrix.image == 'linux_glibc'
+ run: |
+ ./tests/load-test.sh node:16-buster
Review Comment:
The `node:<version>-<suffix>` image just represents a specific node version
and OS. For example, `node:16-buster` represents Node.js 16 and Debian-buster.
CentOS 7 has already been verified when building the `Pulsar.node`. There
are many Linux distributions and they cannot be covered all. And it will
require some extra efforts to install Node.js on them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
