shibd commented on code in PR #288: URL: https://github.com/apache/pulsar-client-node/pull/288#discussion_r1096914611
########## tests/load-test.sh: ########## @@ -0,0 +1,42 @@ +#!/bin/bash Review Comment: Let's try to summarize these scripts: - `./tests/run-unit-test.sh`: Used as unit test verification for running CI, suitable for Linux platforms. So, put it in the `/tests` directory. - `./pkg/load_test.sh`: Used as a validation binary when running CI, suitable for all platforms(Require compile first). So, put it in the `./pkg/` dir. - `./tests/load-test.sh` and `./tests/docker-load-test.sh`:Used as validation binary on multiple platforms in Linux(Require compile first). I think `./tests/load-test.sh` and `./tests/docker-load-test.sh` is used to validate multiple platforms and are not part of unit testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
