BewareMyPower commented on code in PR #288:
URL:
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1073636981
##########
.github/workflows/ci-pr-validation.yml:
##########
@@ -167,6 +167,14 @@ jobs:
docker run -i -v $PWD:/pulsar-client-node build:latest \
/pulsar-client-node/pkg/linux/build-napi-inside-docker.sh
+ - name: Test NAPI file in other containers
+ if: matrix.image == 'linux_glibc'
+ run: |
+ ./tests/load-test.sh node:16-buster
Review Comment:
Just as the GLIBCXX compatibility issue here
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1073622557,
installing Node.js 18 on some systems could be very complicated. The only way
is to compiling it from source. Since NAPI guarantees the ABI compatibility,
why do we insist on verifying with Node.js 18?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
