erobot commented on code in PR #185:
URL: https://github.com/apache/pulsar-client-cpp/pull/185#discussion_r1096909829
##########
lib/AckGroupingTrackerEnabled.h:
##########
@@ -71,6 +71,15 @@ class AckGroupingTrackerEnabled : public AckGroupingTracker {
//! Method for scheduling grouping timer.
void scheduleTimer();
+ //! State
+ enum State
+ {
+ NotStarted,
+ Ready,
+ Closed,
+ };
+ std::atomic<State> state_;
Review Comment:
Using similar state definition style is a first thought and it can use
`atomic_bool isClosed_` instead. May be more explicit. I can change to
isClosed style latter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
