shibd commented on code in PR #185:
URL: https://github.com/apache/pulsar-client-cpp/pull/185#discussion_r1097089878
##########
lib/ConsumerImpl.cc:
##########
@@ -1212,6 +1212,9 @@ void ConsumerImpl::closeAsync(ResultCallback
originalCallback) {
const std::string& ConsumerImpl::getName() const { return consumerStr_; }
void ConsumerImpl::shutdown() {
+ if (ackGroupingTrackerPtr_) {
Review Comment:
> In the current code, if consumer creation failed,
ConsumerImpl::ackGroupingTrackerPtr_ will not close.
BTW, In your case. It seems that the original design was to close resources
in the destructor, but he didn't work.
https://github.com/apache/pulsar-client-cpp/blob/2980bbe9d3ef47eef4a1d468c3898b5a989b4df0/lib/AckGroupingTrackerEnabled.h#L48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
