erobot commented on code in PR #185:
URL: https://github.com/apache/pulsar-client-cpp/pull/185#discussion_r1097117270
##########
lib/ConsumerImpl.cc:
##########
@@ -1212,6 +1212,9 @@ void ConsumerImpl::closeAsync(ResultCallback
originalCallback) {
const std::string& ConsumerImpl::getName() const { return consumerStr_; }
void ConsumerImpl::shutdown() {
+ if (ackGroupingTrackerPtr_) {
Review Comment:
> BTW, In your case. It seems that the original design was to close
resources in the destructor, but he didn't work.
The timer handler is a lambda function which captures a shared_ptr of
AckGroupingTrackerEnabled. Because it always has a reference, so destructor
would not invoke.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
