erobot commented on code in PR #185:
URL: https://github.com/apache/pulsar-client-cpp/pull/185#discussion_r1097109821
##########
lib/ConsumerImpl.cc:
##########
@@ -1212,6 +1212,9 @@ void ConsumerImpl::closeAsync(ResultCallback
originalCallback) {
const std::string& ConsumerImpl::getName() const { return consumerStr_; }
void ConsumerImpl::shutdown() {
+ if (ackGroupingTrackerPtr_) {
Review Comment:
I'm not sure should it be put into the cancelTimers(). Technically, it can
be put into the cancelTimers(). But semantically closing a tracker (which means
flushing the data and canceling the timer) is a little different than canceling
a timer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
