BewareMyPower opened a new pull request, #20848: URL: https://github.com/apache/pulsar/pull/20848
### Motivation https://github.com/apache/pulsar/pull/20496 introduced a breaking change that if the custom authz provider does not implement the `removePermissionsAsync` method, the built-in admin will fail to delete a topic. It's because `BrokerService#deleteTopicAuthenticationWithRetry` calls `authorizationService.removePermissionsAsync`. ### Modifications To make it backward compatible, return a normal completed future in `removePermissionsAsync`. Verify the change by deleting a topic in `AuthorizationWithAuthDataTest#testAdmin`. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
