nodece commented on PR #20848:
URL: https://github.com/apache/pulsar/pull/20848#issuecomment-1645079336

   > It's also very confusing to see the methods added in 
https://github.com/apache/pulsar/pull/20496 don't accept any role argument.
   
   I agree with you. IMO, we suggest adding `String role` and 
`AuthenticationDataSource authData` to these new methods first and fixing the 
return value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to