Technoboy- commented on PR #20848: URL: https://github.com/apache/pulsar/pull/20848#issuecomment-1645085502
> > It's also very confusing to see the methods added in #20496 don't accept any role argument. > > I agree with you. IMO, we suggest adding `String role` and `AuthenticationDataSource authData` to these new methods first and fixing the return value. Yes, I also agree with your idea, but I comment there - [we don't need it right now](https://github.com/apache/pulsar/pull/20496#discussion_r1225348556). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
