michaeljmarshall commented on PR #20848: URL: https://github.com/apache/pulsar/pull/20848#issuecomment-1645018065
> I believe some other APIs are also affected by the behavior of these default methods, like `Topics#getPermissions`, `Namespaces#getPermissionOnSubscription`. It's also very confusing to see the methods added in #20496 don't accept any role argument. This is a good point. I think the Admin API calls to "get permission" assume some kind of centralized data store that has all relevant permissions and can return a meaningful result. In my opinion, the purpose of #20496 was to remove the incorrect logic that always assumed zookeeper stored the correct permissions. Now, the plugin can respond, but not all implementations will have meaningful responses. Further, the "revoke permissions" method is likely irrelevant during topic deletion when permissions are stored external to pulsar. The only reason we revoke permissions on topic deletion is to prevent a leak of this information in zookeeper. > How could users know how to implement them without knowing any role? I assume the best way would be to improve the Javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
