poorbarcode commented on code in PR #21946:
URL: https://github.com/apache/pulsar/pull/21946#discussion_r1468900318
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractReplicator.java:
##########
@@ -206,12 +234,22 @@ protected synchronized CompletableFuture<Void>
closeProducerAsync() {
+ " retrying again in {} s",
replicatorId, ex.getMessage(), waitTimeMs / 1000.0);
// BackOff before retrying
- brokerService.executor().schedule(this::closeProducerAsync,
waitTimeMs, TimeUnit.MILLISECONDS);
+ brokerService.executor().schedule(() ->
closeAsync(onlyCloseProducer),
+ waitTimeMs, TimeUnit.MILLISECONDS);
return null;
});
return future;
}
+ protected void updateStatusAfterCloseProducer(boolean onlyCloseProducer) {
Review Comment:
Renamed
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractReplicator.java:
##########
@@ -163,16 +169,38 @@ public synchronized void startProducer() {
}
- protected void checkTopicActiveAndRetryStartProducer() {
- isLocalTopicActive().thenAccept(isTopicActive -> {
- if (isTopicActive) {
- startProducer();
+ protected void scheduledCheckTopicActiveAndRetryStartProducer(final long
waitTimeMs) {
Review Comment:
fix/orphan_replicator_2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
