poorbarcode commented on code in PR #21946:
URL: https://github.com/apache/pulsar/pull/21946#discussion_r1473737357
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Replicator.java:
##########
@@ -29,9 +29,9 @@ public interface Replicator {
ReplicatorStatsImpl getStats();
- CompletableFuture<Void> disconnect();
+ CompletableFuture<Void> terminate();
- CompletableFuture<Void> disconnect(boolean b);
+ CompletableFuture<Void> terminate(boolean b);
Review Comment:
> `terminate`: you can't restart on the same broker
For now, all the scenarios calling `disconnect` want to close the replicator
😂 , so I modify them to call `terminate.`
> `disconnect`: you can reconnect later.
The method `closeProducerAsync` did the same thing, it only be used in the
Replicator internal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
