poorbarcode commented on PR #21946: URL: https://github.com/apache/pulsar/pull/21946#issuecomment-1914756855
@codelipenghui > And it looks like we can simplify the fix by adding a new method terminate() to the replicator so that we don't need to mix the closeProducer and closeReplicator logic. Sure, renamed `disconnect` to `terminate`. > Is it possible to add a test to cover this case? I will try to write a test laster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
