codelipenghui commented on code in PR #21946:
URL: https://github.com/apache/pulsar/pull/21946#discussion_r1473767965
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Replicator.java:
##########
@@ -29,9 +29,9 @@ public interface Replicator {
ReplicatorStatsImpl getStats();
- CompletableFuture<Void> disconnect();
+ CompletableFuture<Void> terminate();
- CompletableFuture<Void> disconnect(boolean b);
+ CompletableFuture<Void> terminate(boolean b);
Review Comment:
```suggestion
CompletableFuture<Void> terminate(boolean failIfHasBacklog);
```
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Replicator.java:
##########
@@ -29,9 +29,9 @@ public interface Replicator {
ReplicatorStatsImpl getStats();
- CompletableFuture<Void> disconnect();
+ CompletableFuture<Void> terminate();
- CompletableFuture<Void> disconnect(boolean b);
+ CompletableFuture<Void> terminate(boolean b);
Review Comment:
This API looks weird. We should not to fail the termination because
`failIfHasBacklog`? I suppose `failIfHasBacklog` should be a part of
replication disabling, not termination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
