ivankelly commented on a change in pull request #6074: PIP-55: Refresh
Authentication Credentials
URL: https://github.com/apache/pulsar/pull/6074#discussion_r369983759
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -551,29 +624,46 @@ protected void handleConnect(CommandConnect connect) {
if (sslHandler != null) {
sslSession = ((SslHandler) sslHandler).engine().getSession();
}
- originalPrincipal = getOriginalPrincipal(
- connect.hasOriginalAuthData() ? connect.getOriginalAuthData()
: null,
- connect.hasOriginalAuthMethod() ?
connect.getOriginalAuthMethod() : null,
- connect.hasOriginalPrincipal() ?
connect.getOriginalPrincipal() : null,
- sslSession);
authState = authenticationProvider.newAuthState(clientData,
remoteAddress, sslSession);
authenticationData = authState.getAuthDataSource();
- doAuthentication(clientData, clientProtocolVersion, clientVersion);
+ state = doAuthentication(clientData, clientProtocolVersion,
clientVersion);
Review comment:
not for this patch, but it seems strange that this is a synchronous call,
given that authentication could be calling out to a remote system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
