merlimat commented on a change in pull request #6074: PIP-55: Refresh
Authentication Credentials
URL: https://github.com/apache/pulsar/pull/6074#discussion_r370842831
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -235,6 +235,12 @@ message CommandConnect {
optional string original_auth_data = 8;
optional string original_auth_method = 9;
+ // Feature flags
+ optional FeatureFlags feature_flags = 10;
+}
+
+message FeatureFlags {
Review comment:
Bumping the version is a very primitive way of checking the supported
features. It worked well when the client implementation was only Java and
started to be problematic after that.
The reality is that all the clients out there will have a different set of
supported features. Also, if someone just updates the`PulsarApi.proto` it looks
like that client is now at the latest version, while in reality it might not be
able to understand a specific command.
Exchanging the list of supported features will allow client to selectively
implement features.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
