merlimat commented on a change in pull request #6074: PIP-55: Refresh
Authentication Credentials
URL: https://github.com/apache/pulsar/pull/6074#discussion_r370843340
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -551,29 +624,46 @@ protected void handleConnect(CommandConnect connect) {
if (sslHandler != null) {
sslSession = ((SslHandler) sslHandler).engine().getSession();
}
- originalPrincipal = getOriginalPrincipal(
- connect.hasOriginalAuthData() ? connect.getOriginalAuthData()
: null,
- connect.hasOriginalAuthMethod() ?
connect.getOriginalAuthMethod() : null,
- connect.hasOriginalPrincipal() ?
connect.getOriginalPrincipal() : null,
- sslSession);
authState = authenticationProvider.newAuthState(clientData,
remoteAddress, sslSession);
authenticationData = authState.getAuthDataSource();
- doAuthentication(clientData, clientProtocolVersion, clientVersion);
+ state = doAuthentication(clientData, clientProtocolVersion,
clientVersion);
Review comment:
Yes, initially all auth methods were completely stateless and therefore
didn't require any asynchronousness in the provider API. This is not true now
in general and we'll have to make a bit of a refactor to achieve that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
