ivankelly commented on a change in pull request #6074: PIP-55: Refresh
Authentication Credentials
URL: https://github.com/apache/pulsar/pull/6074#discussion_r369978802
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarChannelInitializer.java
##########
@@ -38,6 +48,11 @@
private final NettySslContextBuilder sslCtxRefresher;
private final ServiceConfiguration brokerConf;
+ private final Cache<SocketAddress, ServerCnx> connections =
Caffeine.newBuilder()
Review comment:
nit: Why not Cache<ServerCnx, ServerCnx> and avoid possibly allocating the
SocketAddress? We don't care about the keys in any case. Maybe add a comment
that the you're using Cache to avoid having to clean stuff up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
