lhotari commented on a change in pull request #9673:
URL: https://github.com/apache/pulsar/pull/9673#discussion_r581907537



##########
File path: pulsar-broker/pom.xml
##########
@@ -308,14 +308,14 @@
       <groupId>${project.groupId}</groupId>
       <artifactId>pulsar-functions-api-examples</artifactId>
       <version>${project.version}</version>
-      <scope>test</scope>
+      <scope>provided</scope>

Review comment:
       the reason for this is to get it off the classpath. There shouldn't be a 
need to have it on the classpath. 
   the reason to have the `provided` scope is to add a project dependency 
between this module and pulsar-functions-api-examples. 
`maven-dependency-plugin` is used to copy the `pulsar-functions-api-examples` 
jar file to the build directory.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to