lhotari commented on a change in pull request #9673:
URL: https://github.com/apache/pulsar/pull/9673#discussion_r582947261
##########
File path: pulsar-broker/pom.xml
##########
@@ -308,14 +308,14 @@
<groupId>${project.groupId}</groupId>
<artifactId>pulsar-functions-api-examples</artifactId>
<version>${project.version}</version>
- <scope>test</scope>
+ <scope>provided</scope>
Review comment:
I now pushed a fix which reverts the change from test to provided, but
instead changes the type to `pom` so that the classes aren't added to the
classpath at all.
If the classes are on the classpath, it wouldn't be possible to test loading
the functions from a file or URI since the classes would always get loaded from
the parent classloader which would contain the classes. That is one of the
rationals to make the changes in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
