lhotari commented on pull request #9673: URL: https://github.com/apache/pulsar/pull/9673#issuecomment-788828706
@sijie @merlimat @david-streamlio @jerrypeng @jiazhai @codelipenghui Please review this change and provide feedback. This change is important for improving the build and Pulsar GitHub Actions based CI. One benefit is that it simplifies the building of Pulsar since it reduces the dependencies of pulsar-broker module since it gets rid of the usage of maven-antrun-plugin plugin for copying the .nar files and pulsar-functions-api-examples.jar file to src/test/resources. This is needed so that it's possible to reuse binary artifacts in the Pulsar CI pipeline. For example, in the unit test jobs, it should be possible to reuse the binary artifacts that are built in a previous step instead of building everything with "mvn clean install" in each step. When it's possible to reuse binary artifacts, we can save about 15 minutes for each unit test and integration test build job in the GitHub Action based CI pipeline. In addition to these benefits, this PR fixes real bugs and problems in LocalRunner. Those are described in the description of this PR. Since the improvements of Pulsar CI are blocked by this PR, I'm asking for more reviews and addressable feedback. Thank you ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
