lhotari commented on a change in pull request #9673:
URL: https://github.com/apache/pulsar/pull/9673#discussion_r582909144



##########
File path: pulsar-broker/pom.xml
##########
@@ -308,14 +308,14 @@
       <groupId>${project.groupId}</groupId>
       <artifactId>pulsar-functions-api-examples</artifactId>
       <version>${project.version}</version>
-      <scope>test</scope>
+      <scope>provided</scope>

Review comment:
       actually when thinking more about it, changing from `test` to `provided` 
won't take it off the classpath as I have intended. I guess I should also 
change the type to `pom` so that there's a dependency to the project (so that 
`-am` works), but nothing gets added to the classpath. I'll revisit this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to