lhotari commented on pull request #10032: URL: https://github.com/apache/pulsar/pull/10032#issuecomment-805782751
> I noticed that there's a gap in this PR. There also needs to be handling for these temp files: > > https://github.com/apache/pulsar/blob/602137fa1b87bf3fdb7a99f7fc096d77c0fe40f4/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java#L766 > > https://github.com/apache/pulsar/blob/c27f7a340a3c78a3a5004d08b8ac05ed99672ee3/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SourcesImpl.java#L744 > > https://github.com/apache/pulsar/blob/c27f7a340a3c78a3a5004d08b8ac05ed99672ee3/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SinksImpl.java#L748 I addressed the cleanup of these files by using the nar extraction directory as the temporary directory for these files. I think that it should be ok for that purpose. Adding yet another configuration parameter for the downloaded files would be adding too much overhead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
