jerrypeng commented on a change in pull request #10032:
URL: https://github.com/apache/pulsar/pull/10032#discussion_r600781946
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionE2ETest.java
##########
@@ -457,12 +458,6 @@ private void testE2EPulsarFunction(String jarFilePathUrl)
throws Exception {
// make sure subscriptions are cleanup
assertEquals(admin.topics().getStats(sourceTopic).subscriptions.size(), 0);
});
-
- // make sure all temp files are deleted
- File dir = new File(System.getProperty("java.io.tmpdir"));
- File[] foundFiles = dir.listFiles((dir1, name) ->
name.startsWith("function"));
-
- Assert.assertEquals(foundFiles.length, 0, "Temporary files left over:
" + Arrays.asList(foundFiles));
Review comment:
We should not delete this check because it verifies the temporary
function files will get clean up.
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionE2ETest.java
##########
@@ -457,12 +458,6 @@ private void testE2EPulsarFunction(String jarFilePathUrl)
throws Exception {
// make sure subscriptions are cleanup
assertEquals(admin.topics().getStats(sourceTopic).subscriptions.size(), 0);
});
-
- // make sure all temp files are deleted
- File dir = new File(System.getProperty("java.io.tmpdir"));
- File[] foundFiles = dir.listFiles((dir1, name) ->
name.startsWith("function"));
-
- Assert.assertEquals(foundFiles.length, 0, "Temporary files left over:
" + Arrays.asList(foundFiles));
Review comment:
Based on your PR, you should at least check the download directory to
make sure there are not files in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
