jerrypeng commented on a change in pull request #10032:
URL: https://github.com/apache/pulsar/pull/10032#discussion_r600932380
##########
File path:
pulsar-functions/localrun/src/main/java/org/apache/pulsar/functions/LocalRunner.java
##########
@@ -196,18 +200,37 @@ public LocalRunner(FunctionConfig functionConfig,
SourceConfig sourceConfig, Sin
this.runtimeEnv = runtimeEnv;
this.secretsProviderClassName = secretsProviderClassName;
this.secretsProviderConfig = secretsProviderConfig;
- this.narExtractionDirectory = narExtractionDirectory != null ?
narExtractionDirectory
- : NarClassLoader.DEFAULT_NAR_EXTRACTION_DIR;
+ if (narExtractionDirectory != null) {
Review comment:
We are changing the existing behavior here. If the
narExtractionDirectory is not specified we should default to
NarClassLoader.DEFAULT_NAR_EXTRACTION_DIR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
