lhotari commented on a change in pull request #10032:
URL: https://github.com/apache/pulsar/pull/10032#discussion_r601063158
##########
File path:
pulsar-functions/localrun/src/main/java/org/apache/pulsar/functions/LocalRunner.java
##########
@@ -196,18 +200,37 @@ public LocalRunner(FunctionConfig functionConfig,
SourceConfig sourceConfig, Sin
this.runtimeEnv = runtimeEnv;
this.secretsProviderClassName = secretsProviderClassName;
this.secretsProviderConfig = secretsProviderConfig;
- this.narExtractionDirectory = narExtractionDirectory != null ?
narExtractionDirectory
- : NarClassLoader.DEFAULT_NAR_EXTRACTION_DIR;
+ if (narExtractionDirectory != null) {
Review comment:
The change in behavior is intentional for LocalRunner. The intent of the
changes are that unless narExtractionDirectory is specified, a temporary
directory will be created which is deleted when `LocalRunner.close()` is
called. Do you think that this type of behavior is unacceptable? I hope it
would be ok to do this change since it reduces the chance that temporary files
get left in the main system temp directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
