freeznet commented on a change in pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#discussion_r630648708
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##########
@@ -1397,9 +1399,14 @@ public OffloadProcessStatus offloadStatus(String topic)
WebTarget path = topicPath(tn, "offload");
final CompletableFuture<OffloadProcessStatus> future = new
CompletableFuture<>();
asyncGetRequest(path,
- new InvocationCallback<OffloadProcessStatus>() {
+ new InvocationCallback<String>() {
@Override
- public void completed(OffloadProcessStatus
offloadProcessStatus) {
+ public void completed(String jsonString) {
+ Gson gson = new
GsonBuilder().registerTypeAdapter(MessageId.class,
Review comment:
@merlimat Indeed, there will be some problems with `pulsar-common`. But
if we return Java interfaces instead of POJOs, we still need to have a mapping
list to have Java Interface -> POJO so that `Jackson` can do the
deserialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
