eolivelli commented on a change in pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#discussion_r630953682
##########
File path: pulsar-client-admin-api/pom.xml
##########
@@ -33,16 +33,16 @@
<name>Pulsar Client Admin :: API</name>
<dependencies>
+
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>pulsar-common</artifactId>
<version>${project.parent.version}</version>
</dependency>
<dependency>
- <groupId>${project.groupId}</groupId>
- <artifactId>pulsar-client-original</artifactId>
- <version>${project.parent.version}</version>
+ <groupId>com.google.code.gson</groupId>
+ <artifactId>gson</artifactId>
Review comment:
if gson is not already a dependency imported by pulsar-client-original
in 2.7.x I would like to not add it.
Users of pulsar-client-original already have Jackson and usually who uses
pulsar-client-admin-api uses pulsar-client, so I would lean toward using only
Jackson.
what's your plan for removing gson in a follow up patch ? this next patch
will become a blocker for the 2.8 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
