freeznet commented on a change in pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#discussion_r630958703
##########
File path: pulsar-client-admin-api/pom.xml
##########
@@ -33,16 +33,16 @@
<name>Pulsar Client Admin :: API</name>
<dependencies>
+
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>pulsar-common</artifactId>
<version>${project.parent.version}</version>
</dependency>
<dependency>
- <groupId>${project.groupId}</groupId>
- <artifactId>pulsar-client-original</artifactId>
- <version>${project.parent.version}</version>
+ <groupId>com.google.code.gson</groupId>
+ <artifactId>gson</artifactId>
Review comment:
Adding `gson` as the dependency is a temporary action, with removal of
`pulsar-client-original` and `pulsar-package-core`, `pulsar-client-admin-api`
will lose dependency of `gson`, but we still have a lot of classes import
`gson`, such as
https://github.com/apache/pulsar/blob/581fd5b01e6775db1429f645ffe2ce7d984c2877/pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java#L21.
I do understand that the 2.8 release is in a hurry, but there are indeed
many problems that need to be fixed one by one in order to achieve the ultimate
goal. So the removal of `gson` will be in a separate PR soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
