eolivelli commented on a change in pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#discussion_r630803270
##########
File path: pulsar-io/kafka/pom.xml
##########
@@ -39,6 +39,12 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>pulsar-client-original</artifactId>
Review comment:
yes, @freeznet is right. we need Schema Impl classes
##########
File path:
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/PulsarAdmin.java
##########
@@ -147,11 +146,6 @@ static PulsarAdminBuilder builder() {
*/
String getServiceUrl();
- /**
- * @return the client Configuration Data that is being used
- */
- ClientConfigurationData getClientConfigData();
Review comment:
I believe the this method is pretty useless so I am fine to remove it.
We are also making this change as part of a new major release, so this
"minor" API breaking change is acceptable from my point of view.
I just wanted to double check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
