lizhanhui commented on code in PR #6571:
URL: https://github.com/apache/rocketmq/pull/6571#discussion_r1163959454
##########
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##########
@@ -892,6 +892,10 @@ public CompletableFuture<PutMessageResult>
asyncPutMessage(final MessageExtBroke
} finally {
putMessageLock.unlock();
}
+ // Increase queue offset when messages are successfully written
+ if (AppendMessageStatus.PUT_OK.equals(result.getStatus())) {
Review Comment:
Why is it safe to increase the offset without put-message-lock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
